Skip to content

Implement AST -> HIR generics propagation in delegation #151864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aerooneqq wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Implement AST -> HIR generics propagation in delegation #151864

aerooneqq wants to merge 10 commits into from
+4,166 −378

Conversation

@aerooneqq
Copy link
Contributor

@aerooneqq aerooneqq commented Jan 30, 2026 •
edited
Loading

This PR adds support for generics propagation during AST -> HIR lowering and is a part of #118212.

Nearest future work:

  • Late-bound lifetimes
  • impl Trait params in functions
  • Proper propagation of parent generics when generating method call
  • Fix diagnostics duplication during lowering of user-specified types
  • Support for recursive delegations
  • Self types support reuse <u8 as Trait<_>>::foo as generic_arguments2
  • Decide what to do with infer args reuse Trait::<_, _>::foo::<_>

r? @petrochenkov

@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2026

HIR ty lowering was modified

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 30, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo
Copy link
Member

Kivooeo commented Jan 30, 2026

would it be possible to split this pr to commits?

@petrochenkov
Copy link
Contributor

petrochenkov commented Jan 30, 2026

would it be possible to split this pr to commits?

@aerooneqq is sitting in the same office with me, we'll figure out how to review this better.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
fmease
fmease reviewed Jan 30, 2026
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq aerooneqq force-pushed the delegation-generics-propagation branch from 94fa69b to a6d9e63 Compare February 4, 2026 14:42
@rustbot

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq aerooneqq force-pushed the delegation-generics-propagation branch from a6d9e63 to 9033bc5 Compare February 5, 2026 15:18
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq aerooneqq force-pushed the delegation-generics-propagation branch from 9033bc5 to b398a09 Compare February 9, 2026 14:09
@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aerooneqq @rustbot @rust-log-analyzer @Kivooeo @petrochenkov @fmease